Fix the bisect runner breaking the output
expectation
#3113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bisect runner sets $stdout & $stderr to a StringIO. If your specs include
output.to_stdout_from_any_process
oroutput.to_stderr_from_any_process
, CaptureStreamToTempfile would then introduce new errors during the bisect run, failing withcan't convert Tempfile into StringIO
hereHere's one approach, which instead sets $stdout & $stderr to a Tempfile. WDYT? I know previously we've wanted to avoid adding a dependency on tempfile ... we could instead try fixing this at the rspec-expectations level, though not sure how feasible that is.