Ignore comment lines in option files #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
requested changes
Dec 2, 2022
| @@ -169,7 +169,8 @@ def parse_args_ignoring_files_or_dirs_to_run(args, source) | |||
| def args_from_options_file(path) | |||
| return [] unless path && File.exist?(path) | |||
| config_string = options_file_as_erb_string(path) | |||
| FlatMap.flat_map(config_string.split(/\n+/), &:shellsplit) | |||
| config_lines = config_string.split(/\n+/).reject { |s| s.match?(/\A\s*#/) } | |||
There was a problem hiding this comment.
match?/1 isn't supported by all of our supported Rubies, this would need to change to be merged,
There was a problem hiding this comment.
Thank you for your review. I use =~ instead: 51d6054
JunichiIto
force-pushed
the
ignore-comment-lines-in-option-files
branch
from
c9d9e3b
to
51d6054
Compare
|
Thanks, I fixed the Ruby 3.1 build elsewhere so this is now merged. |
|
Great, thank you! |
|
Released in 3.13.0, apologies it has taken so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2985