This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Fix 1127 in master #1142
Merged
Fix 1127 in master #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what the docs say we do. It's also necessary so that if `configuration.reporter` is accessed before the CommandLine class has set the output_stream, it uses $stdout as its output rather than a `StringIO.new`. Before, issuing a deprecation from `option_parser.rb` was causing no spec output at all since that happened before the output_stream was set.
These specs depended on the reporter defaulting to a `StringIO.new`. Now that it is defaulting to `$stdout`, we were getting unwanted output from these two specs.
Everything else in RSpec uses `output_stream`.
|
/cc @xaviershay @JonRowe |
|
LGTM aside from clarifying question. |
This reverts commit a22d524. This is no longer needed with the new approach we are taking to `output_stream` (e.g. having it default to $stdout), and it was causing `command_line_spec.rb` to have a failure when run in isolation.
We don't care about it here.
This was referenced Nov 4, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix for #1127 in master, corresponding to #1141.