Skip to content

Comments

added closed connection callback#17

Closed
lashket wants to merge 1 commit intorsocket:masterfrom
lashket:master
Closed

added closed connection callback#17
lashket wants to merge 1 commit intorsocket:masterfrom
lashket:master

Conversation

@lashket
Copy link

@lashket lashket commented Apr 5, 2022

Added callback to be notified when Websocket is closed

@cryptpa
Copy link

cryptpa commented Apr 5, 2022

you are the man!!! What about closing the request stream connection.

@marinkobabic
Copy link

Why is this pull request still open?

@szymek-pindelski
Copy link

hello,
does this pull request have something to do with active stream subscriptions surviving RSocket.close() ?
My stream subscription does not seem to notice that rsocket has been closed, and I need to explicitly cancel it (in case you're wondering - I'm using websocket as transport layer)
I read somewhere that RSocket.close() is supposed to cancel any active subscriptions but it's clearly not the case with RSocket Dart implementation

@lashket lashket closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants