Skip to content

Do not allow lines of identify output containing whitespace only to crash the whole show #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not allow lines of identify output containing whitespace only to crash the whole show #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions imagemagick.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,12 @@ function parseIdentify(input) {
prevIndent = indents[indents.length - 1];
}
if (comps.length < 2) {
props.push(prop);
prop = prop[currentLine.split(':')[0].trim().toLowerCase()] = {};
// Don't allow bad lines of output, as seen in the rdf property, to
// crash the whole show. Make sure there is a : present
if (currentLine.indexOf(':') !== -1) {
props.push(prop);
prop = prop[currentLine.split(':')[0].trim().toLowerCase()] = {};
}
} else {
prop[comps[0].trim().toLowerCase()] = comps[1].trim()
}
Expand Down