No result geometry fix #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1 Please merge this |
|
+1 |
|
Added this to my code locally and does not fix the issue. However the issue is still here... |
|
IMO, ideally the PR should try to identify and fix the underlying issue, or at least explain in which circumstances the tool won't be able to tell the image's geometry. This PR only mutes the issue. I can't image a scenario where I need the image width/height and be able to function properly without this info. If Imagemagick can't tell me what's the width/height then I'm not sure what else on earth would give me this information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node is crushing if result does not contain geometry.