Broken sourcemaps

[jimrandomh]

After each build, patchSourceMap modifies the source-maps esbuild emitted, deleting the sourcesContent field and setting sourceRoot to a relative path from the output directory to the working directory. In practice, if the output file is a webap, this breaks source mapping; the relative path doesn't point anywhere sensible when it's treated as a UR. Commenting out the call to patchSourceMap fixes it, as does using sourcemap:"inline" (but the latter drastically increases the size of the output javascript bundle).

[rsms]

I've dug into it and it seems esbuild now generates "good" sourcemaps. I'm removing the patching code with one exception: When you generate a sourcemap but no output javascript, the paths of the sources themselves need to be patched no matter what. (there's a test for this at test/tempfile-output)

With the changes I'm about to land, you can now ask for sourcesContent by providing the (esbuild-inherited) option sourcesContent like so:

build({
  sourcemap: true, // or inline or filename
  sourcesContent: true,
})

This will cause esbuild to include sourcesContent in your sourcemap

[rsms]

Shipped with release 1.4.0