-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some issues on RIT workflow #2724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmacleal
force-pushed
the
fix/solving_issues_rit_workflow
branch
30 times, most recently
from
September 13, 2024 15:28
e8d0d70
to
21bd4af
Compare
lucasvuotto
reviewed
Sep 19, 2024
Co-authored-by: Lucas <[email protected]>
lucasvuotto
previously approved these changes
Sep 19, 2024
lucasvuotto
reviewed
Sep 19, 2024
Co-authored-by: Lucas <[email protected]>
lucasvuotto
reviewed
Sep 19, 2024
Co-authored-by: Lucas <[email protected]>
Co-authored-by: Lucas <[email protected]>
fmacleal
force-pushed
the
fix/solving_issues_rit_workflow
branch
from
September 20, 2024 12:29
8bb54ac
to
9c97b9d
Compare
lucasvuotto
reviewed
Sep 20, 2024
Co-authored-by: Lucas <[email protected]>
fmacleal
force-pushed
the
fix/solving_issues_rit_workflow
branch
5 times, most recently
from
September 23, 2024 16:17
bd6e50e
to
493afe5
Compare
fmacleal
force-pushed
the
fix/solving_issues_rit_workflow
branch
from
September 23, 2024 17:40
493afe5
to
0d91f89
Compare
Quality Gate passedIssues Measures |
Vovchyk
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed:
1 - Remove the trigger on push for master and *-rc -> we don't need that anymore since we are running it for every commit on PRs against these branches.
2 - Send the status of the execution to slack
3 - Solve the issue that the status of an execution triggered via workflow doesn't update the PR status.
And if we need to use a different branch for RIT, Powpeg and RIT in the PR, it won't change the status to
green after the workflow_dispatch execution -> We will do that adding a parsing on the description, looking
for the branch that need to be used for that PR. If there is no branch configured on the description, we will
try to use the default one.
Branches to be used by RIT:
fed:vovchyk/jackson-ver-bump
rskj:vovchyk/jackson-ver-bump
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: