Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Comments

fix: update async-stream to 0.3#288

Merged
bors[bot] merged 1 commit intors-ipfs:masterfrom
eqlabs:update_async_stream
Aug 6, 2020
Merged

fix: update async-stream to 0.3#288
bors[bot] merged 1 commit intors-ipfs:masterfrom
eqlabs:update_async_stream

Conversation

@koivunej
Copy link
Collaborator

@koivunej koivunej commented Aug 6, 2020

this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s).

good to go if CI passes.

this uses the rust 1.45 features to remove recursion inside the macro.
great for rs-ipfs#284 which adds even more complicated async-stream(s).
@koivunej koivunej requested a review from ljedrz August 6, 2020 08:11
Copy link
Member

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

bors bot added a commit that referenced this pull request Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej

this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s).

good to go if CI passes.

Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
@ljedrz
Copy link
Member

ljedrz commented Aug 6, 2020

Same errors I got in #287, it seems; hopefully bors will follow through regardless.

@bors
Copy link
Contributor

bors bot commented Aug 6, 2020

Build failed:

@ljedrz
Copy link
Member

ljedrz commented Aug 6, 2020

bors retry

bors bot added a commit that referenced this pull request Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej

this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s).

good to go if CI passes.

Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
@bors
Copy link
Contributor

bors bot commented Aug 6, 2020

Build failed:

@koivunej
Copy link
Collaborator Author

koivunej commented Aug 6, 2020

npm is having a partial outage.

bors retry

bors bot added a commit that referenced this pull request Aug 6, 2020
288: fix: update async-stream to 0.3 r=ljedrz a=koivunej

this uses the rust 1.45 features to remove recursion inside the macro. great for #284 which adds even more complicated async-stream(s).

good to go if CI passes.

Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
@bors
Copy link
Contributor

bors bot commented Aug 6, 2020

Build failed:

@ljedrz
Copy link
Member

ljedrz commented Aug 6, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 6, 2020

Build succeeded:

@bors bors bot merged commit 47d2674 into rs-ipfs:master Aug 6, 2020
@koivunej koivunej deleted the update_async_stream branch September 24, 2020 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants