Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rrweb: add selection observer #936

Merged
merged 7 commits into from
Aug 6, 2022
Merged

rrweb: add selection observer #936

merged 7 commits into from
Aug 6, 2022

Conversation

0jinxing
Copy link
Contributor

support selection change record and replay

@Yuyz0112
Copy link
Member

@0jinxing Thanks! This looks interesting, could you provide more information about the use case of this feature, and a short video demo for the replay effect?

BTW, e2e test cases are required.

@YunFeng0817
Copy link
Member

@0jinxing Thanks for your excellent feature contribution.
I made a simple demo with your code and the effect is fantastic!

record.mp4
replay.mp4

I am looking forward to seeing the complementation and merge of this PR!

YunFeng0817
YunFeng0817 requested changes Jul 31, 2022
View reviewed changes
packages/rrweb/src/replay/index.ts Outdated Show resolved Hide resolved
packages/rrweb/src/record/observer.ts Outdated Show resolved Hide resolved
packages/rrweb/src/record/observer.ts Outdated Show resolved Hide resolved
@0jinxing 0jinxing force-pushed the master branch 2 times, most recently from dc5d8d6 to c3295f0 Compare August 3, 2022 09:35
@0jinxing 0jinxing requested a review from YunFeng0817 August 3, 2022 09:52
@0jinxing 0jinxing requested a review from YunFeng0817 August 3, 2022 11:38
YunFeng0817
YunFeng0817 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0jinxing Thanks for your quick modification and reply! Hope to see it merged soon.

@YunFeng0817 YunFeng0817 requested a review from Yuyz0112 August 3, 2022 13:49
@Yuyz0112
Copy link
Member

Yuyz0112 commented Aug 6, 2022

Thanks, let's merge it!

@Yuyz0112 Yuyz0112 merged commit b2d5689 into rrweb-io:master Aug 6, 2022
@YunFeng0817 YunFeng0817 mentioned this pull request Aug 10, 2022
Merged
@Juice10 Juice10 added the 2.0 label Dec 1, 2022
eoghanmurray
eoghanmurray reviewed Dec 15, 2022
View reviewed changes
packages/rrweb/src/record/observer.ts

updateSelection();

return on('selectionchange', updateSelection);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The on function here expects a third 'target' argument; I presume it should be doc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0jinxing can you confirm that it should be doc passed as the third argument?
Otherwise it's trying to addEventListener on undefined

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YunFeng0817 I'm not sure how this has escaped everyone's notice if it's been merged!

This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoghanmurray eoghanmurray eoghanmurray left review comments

@YunFeng0817 YunFeng0817 YunFeng0817 approved these changes

@Yuyz0112 Yuyz0112 Awaiting requested review from Yuyz0112

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0jinxing @Yuyz0112 @YunFeng0817 @eoghanmurray @Juice10