Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Uncaught TypeError: Illegal invocation when recording incremental canvas mutation #844

Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix: Uncaught TypeError: Illegal invocation when recording incremental canvas mutation #844

merged 1 commit into from
Feb 24, 2022

Conversation

YunFeng0817
Copy link
Member

reproducible code: https://codepen.io/mark-fenng/pen/JjOZBdN?editors=1111
image
Steps to reproduce the error:
First, click ‘start to record’, then click ‘create a canvas’ and the error will just show up.

Thanks for @Juice10's fix!

Juice10
Juice10 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@Juice10 Juice10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Fenng Thanks for creating such a great reproduction environment!

@Yuyz0112 Yuyz0112 merged commit 5ae208b into master Feb 24, 2022
@linear linear bot mentioned this pull request Feb 24, 2022
Merged
@YunFeng0817 YunFeng0817 deleted the canvas-fix branch March 3, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juice10 Juice10 Juice10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YunFeng0817 @Juice10 @Yuyz0112