Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support media playbackRate #1000

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

wfk007
Copy link
Contributor

@wfk007 wfk007 commented Sep 15, 2022

add support for media playbackRate change

Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code looks good. To pass the prettier check CI, you may need to rebase the branch with the latest main branch and fix the format problem in observer.ts as well.

packages/rrdom/src/document.ts Show resolved Hide resolved
packages/rrdom/src/diff.ts Show resolved Hide resolved
@wfk007 wfk007 force-pushed the support-media-playbackRate branch from 0db9cda to 6e0f348 Compare September 15, 2022 04:58
@wfk007 wfk007 force-pushed the support-media-playbackRate branch from 8b6e958 to ed2981a Compare September 15, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants