Closed
Conversation
This is what Riverpod does, so it's probably fine? It also makes it easier to browse the code on GitHub.
This again... dart-lang/sdk#60784
Mis-merge-conflict-resolved this I think.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lishaduck
force-pushed
the
analyzer-8
branch
from
28eb917 to
91c43cf
Compare
Contributor
Author
|
Ok, looks like this PR is good except for getting setting correct lower bounds somewhere (and obv. publishing dependent packages) |
lishaduck
force-pushed
the
analyzer-8
branch
from
63b72aa to
5d34848
Compare
Owner
|
Handled separately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1185.
Depends on invertase/dart_custom_lint#354.