Support Dart 3.6.0 and analyzer 6.9.0 as a minimum.#1192
Support Dart 3.6.0 and analyzer 6.9.0 as a minimum.#1192rrousselGit merged 7 commits intorrousselGit:masterfrom
Conversation
WalkthroughThe changes update version requirements and documentation for the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Dart 3.7 is needed for |
|
I see. Would it be possible to simply document that the "no-format" option is only available when opting into Dart 3.7? Given the controversy on the new formatter rules, I believe there will be some folks that won't opt into Dart 3.7 for a while. And if freezed can work in a 99% of its features with 3.6, I think it would be worth the change. |
|
Fair. Do you mind documenting it? |
|
@rrousselGit Done. Is it ok in the README? |
|
Sounds good. Do you mind fixing the CI? |
|
@rrousselGit How should we fix it? Go back to the 3.6 formatter and reformat the whole source code? The new format only runs when targeting 3.7 as a minimum |
|
Sure. Whatever makes the CI happy, I don't care |
|
Is there anything else you think should be done here? @rrousselGit |
|
LGTM thanks! |
Was there any reason for limiting the analyzer dependency to v7 and Dart to 3.7 ?
The freezed core dependencies such as source gen support analyzer 6.9.0 and Dart 3.6.
I tried running the tests and examples in Flutter 3.27 (Dart 3.6) and everything works great. (I had to locally patch these changes though, as it appears the example is not up to date) #1183
Summary by CodeRabbit
Complexclass for simplification.