Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook useDebounced #395

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Add hook useDebounced #395

merged 3 commits into from
Dec 5, 2023

Conversation

itisnajim
Copy link
Contributor

Following our earlier discussion in the PR at:
#394 (comment)

it's clear that integrating the useDebounced hook will be quite beneficial!

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc0eab8) 99.87% compared to head (65e95b8) 99.88%.

❗ Current head 65e95b8 differs from pull request most recent head 6e77daa. Consider uploading reports for the commit 6e77daa to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   99.87%   99.88%           
=======================================
  Files          20       21    +1     
  Lines         830      858   +28     
=======================================
+ Hits          829      857   +28     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itisnajim
Copy link
Contributor Author

I believe all should be well at this point

  • Using timeout as a positional argument instead of named.
  • Adding more comments/docs.
  • Removing setValue() as its unnecessary.
  • Double checking and fixing tests.
    0d3f71f

@rrousselGit rrousselGit merged commit f89eda0 into rrousselGit:master Dec 5, 2023
1 check passed
@rrousselGit
Copy link
Owner

Looking good, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants