Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from sandboxie-plus:master #338

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 18, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Enhance font management in the CCodeEdit class by adding methods to set and get the font. Fix the INI editor font selection issue that arose after adding the INI highlighting feature. Update the changelog to reflect these changes.

Bug Fixes:

  • Fixed the issue where the INI editor font selection was not working after the INI highlighting feature was added.

Enhancements:

  • Added methods to set and get the font in the CCodeEdit class, improving font management.

Documentation:

  • Updated the changelog to include the fix for the INI editor font selection issue.

@pull pull bot added the ⤵️ pull label Dec 18, 2024
@pull pull bot merged commit 83751d8 into rrosajp:master Dec 18, 2024
Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This PR implements font handling improvements in the code editor component of Sandboxie Plus. The changes primarily focus on encapsulating font-related functionality in the CCodeEdit class and fixing font selection issues in the settings windows.

Class diagram for CCodeEdit font handling improvements

classDiagram
    class CCodeEdit {
        +void SetCode(QString Code)
        +QString GetCode()
        +void SetFont(QFont Font)
        +const QFont& GetFont() const
        void textChanged()
    }
    note for CCodeEdit "Added SetFont and GetFont methods for font handling"
Loading

File-Level Changes

Change Details Files
Added font management methods to the code editor component
  • Added SetFont method to set the font for the source code editor
  • Added GetFont method to retrieve the current font from the source code editor
SandboxiePlus/MiscHelpers/Common/CodeEdit.h
SandboxiePlus/MiscHelpers/Common/CodeEdit.cpp
Fixed font selection functionality in settings windows
  • Updated font application logic to use the new CCodeEdit font methods
  • Removed redundant boolean variable in font string parsing
  • Fixed font dialog integration with the code editor
SandboxiePlus/SandMan/Windows/SettingsWindow.cpp
SandboxiePlus/SandMan/Windows/OptionsWindow.cpp
Updated changelog with font selection fix CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant