Remove register_retire from rfpkg#25
Merged
sergiomb2 merged 1 commit intorpmfusion-infra:masterfrom Jun 27, 2022
Merged
Conversation
Don't register again the retire command as it is already done by pyrpkg. Starting Python 3.11, it creates an error. See python/cpython#18605 Fix rpmfusion-infra#24
Author
|
The only difference was the wording: versus Not sure it makes such a big difference. I've searched for other methods, but there is no provision for removing a parser (proposed in 2015 but not pursued) or modifying an existing parser. |
Member
|
and with python 3.10 (or previous) this works ? |
Author
|
I have not tested it, but there is no reason it wouldn't. Adding twice the same subparsers was not something that was supposed to be done. Python 3.11 made it into an error, but there is no other behaviour change wrt Python 3.10 ad earlier. |
Member
|
ah ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't register again the retire command as it is already done
by pyrpkg. Starting Python 3.11, it creates an error.
See python/cpython#18605
Fix #24