lib/transaction: Don't SEGV in sync if a txn was failed#319
Closed
cgwalters wants to merge 1 commit intorpm-software-management:masterfrom
Closed
lib/transaction: Don't SEGV in sync if a txn was failed#319cgwalters wants to merge 1 commit intorpm-software-management:masterfrom
cgwalters wants to merge 1 commit intorpm-software-management:masterfrom
Conversation
I was actually testing a change to better handle `rpm -e atomic` on Fedora Atomic Host, wondering why my patch was crashing, but in fact it was the recently added sync code in master.
Member
|
Right, it shouldn't crash. But disabled disk-space checking silently disabling sync is wrong too. |
Member
|
Fixed differently (cause instead of symptom) in commits 9e65d6e and 7481f0f: number of transaction elements was the wrong condition for syncing, sync should only be done if transaction actually ran. The second commit ensures syncing doesn't depend on diskspace problem filter (but forgot to mention that particular reason in the commit message, doh) Anyway, thanks for pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was actually testing a change to better handle
rpm -e atomicon FedoraAtomic Host, wondering why my patch was crashing, but in fact it was the
recently added sync code in master.