Regression: addtional output in rpmspec with -q #3413
Comments
|
This will happen with any spec using Buildsystem, there's no difference from any 4.20 preversion to upstream git master so it's not a regression within Buildsystem-using packages, but for rpmspec in general yes. Luckily it's also trivial to fix. |
Dynamic spec parsing emits "Reading <path>" messages to make it clear something out of the ordinary is going on, but this is undesireable on rpmspeq queries. Luckily there's a trivial solution: rpmbuild where you want these messages runs in verbose mode by default whereas rpmspec does not. So just moving the message to INFO level does exactly the right thing in both the above cases and as an added bonus, rpmbuild --quiet too. Add a test to go. Fies: rpm-software-management#3413
In rpmspec, -q means query, not quiet. rpmbuild is verbose by default, rpmspec is not, it's just that the "Reading..." message was in the "wrong" level for this purpose, in the original context dynamic spec parsing only occurred during builds and not plain spec parsing.
rpmspec queries the binary packages by default, so you get one line of output per each subpackage, this is how it's always been and not a bug. If you want to query the source rpm instead (of which there will obviously only be one), use |
Dynamic spec parsing emits "Reading <path>" messages to make it clear something out of the ordinary is going on, but this is undesireable on rpmspec queries. Luckily there's a trivial solution: rpmbuild where you want these messages runs in verbose mode by default whereas rpmspec does not. So just moving the message to INFO level does exactly the right thing in both the above cases. Add a test to go. Fies: rpm-software-management#3413
Dynamic spec parsing emits "Reading <path>" messages to make it clear something out of the ordinary is going on, but this is undesireable on rpmspec queries. Luckily there's a trivial solution: rpmbuild where you want these messages runs in verbose mode by default whereas rpmspec does not. So just moving the message to INFO level does exactly the right thing in both the above cases. Add a test to go. Fies: rpm-software-management#3413
Dynamic spec parsing emits "Reading <path>" messages to make it clear something out of the ordinary is going on, but this is undesireable on rpmspec queries. Luckily there's a trivial solution: rpmbuild where you want these messages runs in verbose mode by default whereas rpmspec does not. So just moving the message to INFO level does exactly the right thing in both the above cases. Add a test to go. Fies: #3413
|
Fixed by #3414, just a typo in the Fixes clause, doh. |
|
Oh and thanks for reporting! |
Describe the bug
When I run:
on this spec file https://src.fedoraproject.org/rpms/cfn-lint/blob/rawhide/f/cfn-lint.spec
I get:
which is more lines than expected and contains line that should be on stderr (or not printed at all because of
-q)To Reproduce
Steps to reproduce the behavior:
Please link or attach the packages or spec files involved.
Expected behavior
I expected that the line
Reading /var/tmp/rpm-tmp.bSC32Xis not present, because I used-qoption.And I would expect the line with the license printed only once.
Output
Environment
Additional context
I believe this did not happened a week ago (when I used F41 Beta).
The text was updated successfully, but these errors were encountered: