mock: avoid the %pre scriptlet if possible #1498
Open
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be simpler to just vendor the script in the packaging so that it works everywhere? |
|
Nah, what a tiring dark packaging corner :-( I'm not sure. Not sure I understand what you are saying; |
praiskup
force-pushed
the
praiskup-sysusers-pre
branch
from
696f3dd
to
3c6751d
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Nov 1, 2024
Complements: rpm-software-management#1367 Relates: rpm-software-management#289 Closes: rpm-software-management#1498 Relates: fedora-copr/copr#2789
praiskup
force-pushed
the
praiskup-sysusers-pre
branch
from
3c6751d
to
73c571d
Compare
|
@Conan-Kudo PTAL |
|
@Conan-Kudo does it make sense now? |
|
I think I did what you mentioned (not sure). This is tricky though, it would be nice to see a "reference" implementation. |
Conan-Kudo
approved these changes
Nov 11, 2024
Conan-Kudo
requested changes
Nov 11, 2024
Complements: rpm-software-management#1367 Relates: rpm-software-management#289 Closes: rpm-software-management#1498 Relates: fedora-copr/copr#2789 Co-authored-by: Neal Gompa (ニール・ゴンパ) <[email protected]>
praiskup
force-pushed
the
praiskup-sysusers-pre
branch
from
84b77f1
to
55bdb65
Compare
|
ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script for generating the %pre scriptlet is non-existing on new distributions (like Mageia now, but Fedora will drop that sooner or later, too). The build of Mock on Mageia previously relied on sysusers.generate-pre.sh, and failed.
The sysusers feature is an RPM built-in anyway (on modern systems), so there's no reason to duplicate the logic in %pre. Generate the %pre scriptlet only for older distributions.
Complements: #1367
Relates: #289
Relates: fedora-copr/copr#2789