Add `hy_goal_favor` and `hy_goal_disfavor` by jlebon · Pull Request #937 · rpm-software-management/libdnf

jlebon · 2020-04-14T20:48:30Z

Minimal wrappers around SOLVER_FAVOR and SOLVER_DISFAVOR. We'd like
to make use of these in rpm-ostree.

jlebon · 2020-04-20T13:13:47Z

Any thoughts on this?

j-mracek · 2020-04-22T09:32:55Z

@jlebon Please could you provide information for what purpose (user-case) you want to use solver_favor?

j-mracek · 2020-04-22T09:35:04Z

@jlebon Based also on user-case we would like to have some test, to guarantee that it does what is expected.

Conan-Kudo · 2020-04-22T09:52:06Z

SOLVER_FAVOR (and its opposing counterpart SOLVER_DISFAVOR) were added by @mlschroe to libsolv to implement the capability to support urpmi's prefer.vendor.list feature in DNF and other package managers. The idea is that you could maintain an externalized list of preferences that the solver would account for that could be dynamically managed without requiring building an empty package with a pile of Suggests to influence the transaction.

Minimal wrappers around `SOLVER_FAVOR` and `SOLVER_DISFAVOR`. We'd like to make use of these in rpm-ostree.

This is the same thing we already have for e.g. `DnfReldepList`. These helpers are really useful to keep C client code clean and make it harder to leak resources.

jlebon · 2020-04-22T15:33:34Z

OK, now added tests for this and added hy_goal_disfavor for completeness!

@jlebon Please could you provide information for what purpose (user-case) you want to use solver_favor?

Yes, this will allow us to have more influence over libsolv's decisions. Without this, it's impossible to make libsolv "prefer" a package but still letting it not be part of a possible solution. For more details on the rpm-ostree use case, see coreos/rpm-ostree#2059. The goal there is for "locked" packages to be given preference when updating the lockfile, but still allow solutions which require picking packages outside the lockfile.

j-mracek · 2020-04-23T14:16:32Z

LGTM!

j-mracek · 2020-04-23T14:16:49Z

@rh-atomic-bot r+

rh-atomic-bot · 2020-04-23T14:16:50Z

📌 Commit 83b1d62 has been approved by j-mracek

rh-atomic-bot · 2020-04-23T15:01:14Z

⌛ Testing commit 83b1d62 with merge 702b9db...

Minimal wrappers around `SOLVER_FAVOR` and `SOLVER_DISFAVOR`. We'd like to make use of these in rpm-ostree. Closes: #937 Approved by: j-mracek

This is the same thing we already have for e.g. `DnfReldepList`. These helpers are really useful to keep C client code clean and make it harder to leak resources. Closes: #937 Approved by: j-mracek

rh-atomic-bot · 2020-04-23T16:02:22Z

💔 Test failed - status-papr

jlebon · 2020-04-23T16:10:41Z

Hmm, hard to tell what failed. I see:

1 feature passed, 0 failed, 0 skipped
42 scenarios passed, 0 failed, 0 skipped
168 steps passed, 0 failed, 0 skipped, 0 undefined
Took 0m9.261s
+ :
+ popd
/var/lib/jenkins/workspace/dnf-libdnf-test
[dnf-libdnf-test] $ python /tmp/jenkins2264749669589379953.py
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

The last few runs of dnf-libdnf-test failed the same way, so I think it's unrelated to this PR?

Ahhh, I think it might be related to this:

Exception PermissionError: [Errno 13] Permission denied: '/junit/features'
Traceback (most recent call last):
  File "/usr/bin/behave", line 11, in <module>
    load_entry_point('behave==1.2.6', 'console_scripts', 'behave')()
  File "/usr/lib/python3.7/site-packages/behave/__main__.py", line 183, in main
    return run_behave(config)
  File "/usr/lib/python3.7/site-packages/behave/__main__.py", line 127, in run_behave
    failed = runner.run()
  File "/usr/lib/python3.7/site-packages/behave/runner.py", line 804, in run
    return self.run_with_paths()
  File "/usr/lib/python3.7/site-packages/behave/runner.py", line 824, in run_with_paths
    return self.run_model()
  File "/usr/lib/python3.7/site-packages/behave/runner.py", line 640, in run_model
    reporter.feature(feature)
  File "/usr/lib/python3.7/site-packages/behave/reporter/junit.py", line 264, in feature
    os.makedirs(self.config.junit_directory)
  File "/usr/lib64/python3.7/os.py", line 211, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/lib64/python3.7/os.py", line 211, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/lib64/python3.7/os.py", line 221, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/junit/features'

j-mracek · 2020-04-23T19:06:19Z

Lets try it again

j-mracek · 2020-04-23T19:06:28Z

@rh-atomic-bot retry

rh-atomic-bot · 2020-04-23T19:06:35Z

⌛ Testing commit 83b1d62 with merge b6dac7b...

Minimal wrappers around `SOLVER_FAVOR` and `SOLVER_DISFAVOR`. We'd like to make use of these in rpm-ostree. Closes: #937 Approved by: j-mracek

This is the same thing we already have for e.g. `DnfReldepList`. These helpers are really useful to keep C client code clean and make it harder to leak resources. Closes: #937 Approved by: j-mracek

rh-atomic-bot · 2020-04-23T19:58:00Z

💔 Test failed - status-papr

m-blaha · 2020-04-24T09:51:15Z

Sorry guys - misconfiguration in jenkins job. Should by fixed now.

m-blaha · 2020-04-24T09:51:25Z

@rh-atomic-bot retry

rh-atomic-bot · 2020-04-24T09:58:30Z

⌛ Testing commit 83b1d62 with merge 7ae9be8...

This is the same thing we already have for e.g. `DnfReldepList`. These helpers are really useful to keep C client code clean and make it harder to leak resources. Closes: #937 Approved by: j-mracek

rh-atomic-bot · 2020-04-24T10:53:39Z

☀️ Test successful - status-papr
Approved by: j-mracek
Pushing 7ae9be8 to dnf-4-master...

The problem was introduced by rpm-software-management#937 The PR added a new pkg with a require into the updates test repo therefore their count increased.

The problem was introduced by #937 The PR added a new pkg with a require into the updates test repo therefore their count increased. Closes: #947 Approved by: m-blaha

The problem was introduced by #937 The PR added a new pkg with a require into the updates test repo therefore their count increased.

jlebon mentioned this pull request Apr 14, 2020

core: Use SOLVER_FAVOR in relaxed mode coreos/rpm-ostree#2059

Closed

j-mracek self-assigned this Apr 22, 2020

jlebon added 2 commits April 22, 2020 11:28

Add hy_goal_favor and hy_goal_disfavor

541ffa3

Minimal wrappers around `SOLVER_FAVOR` and `SOLVER_DISFAVOR`. We'd like to make use of these in rpm-ostree.

Define a cleanup function for DnfPackageSet

83b1d62

This is the same thing we already have for e.g. `DnfReldepList`. These helpers are really useful to keep C client code clean and make it harder to leak resources.

jlebon force-pushed the pr/favor branch from 1efe005 to 83b1d62 Compare April 22, 2020 15:29

jlebon changed the title ~~Add hy_goal_favor~~ Add hy_goal_favor and hy_goal_disfavor Apr 22, 2020

rh-atomic-bot pushed a commit that referenced this pull request Apr 23, 2020

Add hy_goal_favor and hy_goal_disfavor

f20b171

Minimal wrappers around `SOLVER_FAVOR` and `SOLVER_DISFAVOR`. We'd like to make use of these in rpm-ostree. Closes: #937 Approved by: j-mracek

rh-atomic-bot pushed a commit that referenced this pull request Apr 23, 2020

Add hy_goal_favor and hy_goal_disfavor

176fcd6

Minimal wrappers around `SOLVER_FAVOR` and `SOLVER_DISFAVOR`. We'd like to make use of these in rpm-ostree. Closes: #937 Approved by: j-mracek

rh-atomic-bot closed this in 9f2c03f Apr 24, 2020

kontura added a commit to kontura/libdnf that referenced this pull request Apr 27, 2020

fix failing python unit test

0dee7dc

The problem was introduced by rpm-software-management#937 The PR added a new pkg with a require into the updates test repo therefore their count increased.

kontura mentioned this pull request Apr 27, 2020

fix failing python unit test #947

Merged

rh-atomic-bot pushed a commit that referenced this pull request Apr 27, 2020

fix failing python unit test

805290b

The problem was introduced by #937 The PR added a new pkg with a require into the updates test repo therefore their count increased. Closes: #947 Approved by: m-blaha

rh-atomic-bot pushed a commit that referenced this pull request Apr 27, 2020

fix failing python unit test

bfbfa2e

The problem was introduced by #937 The PR added a new pkg with a require into the updates test repo therefore their count increased. Closes: #947 Approved by: m-blaha

rh-atomic-bot pushed a commit that referenced this pull request Apr 27, 2020

fix failing python unit test

685bf81

The problem was introduced by #937 The PR added a new pkg with a require into the updates test repo therefore their count increased. Closes: #947 Approved by: m-blaha

m-blaha pushed a commit that referenced this pull request Apr 27, 2020

fix failing python unit test

a6e97c2

The problem was introduced by #937 The PR added a new pkg with a require into the updates test repo therefore their count increased.

Conversation

jlebon commented Apr 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jlebon commented Apr 20, 2020

Uh oh!

j-mracek commented Apr 22, 2020

Uh oh!

j-mracek commented Apr 22, 2020

Uh oh!

Conan-Kudo commented Apr 22, 2020

Uh oh!

jlebon commented Apr 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

j-mracek commented Apr 23, 2020

Uh oh!

j-mracek commented Apr 23, 2020

Uh oh!

rh-atomic-bot commented Apr 23, 2020

Uh oh!

rh-atomic-bot commented Apr 23, 2020

Uh oh!

rh-atomic-bot commented Apr 23, 2020

Uh oh!

jlebon commented Apr 23, 2020

Uh oh!

j-mracek commented Apr 23, 2020

Uh oh!

j-mracek commented Apr 23, 2020

Uh oh!

rh-atomic-bot commented Apr 23, 2020

Uh oh!

rh-atomic-bot commented Apr 23, 2020

Uh oh!

m-blaha commented Apr 24, 2020

Uh oh!

m-blaha commented Apr 24, 2020

Uh oh!

rh-atomic-bot commented Apr 24, 2020

Uh oh!

rh-atomic-bot commented Apr 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jlebon commented Apr 14, 2020 •

edited

Loading

jlebon commented Apr 22, 2020 •

edited

Loading