Document --strict deprecation #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
requested changes
Feb 28, 2023
CHANGES-DNF-5.md
Outdated
| `--strict` option is now deprecated. The problem with this option is that it does two things: | ||
|
|
||
| 1. it allows the solver to skip uninstallable packages to resolve depsolv problems | ||
| 2. it allowd dnf to skip unavailable packages (this is for `install` command mostly) |
CHANGES-DNF-5.md
Outdated
| @@ -49,6 +49,14 @@ options and implemented only for related commands | |||
| Renaming boolean options to format `--<option>`, and `--no-<option>` | |||
| `--nobest` -> `--no-best`. Proposing to keep `--nobest` as a deprecated option. | |||
|
|
|||
| ### --strict deprecation | |||
| `--strict` option is now deprecated. The problem with this option is that it does two things: | |||
There was a problem hiding this comment.
If I understand correctly I would maybe reword it a bit:
- isn't the
strictoption a config option? I can't find any--strictswitch - I would say if the strict option was disabled it allows those two things, currently to me the text suggests that if the option was enabled it allows those things.
There was a problem hiding this comment.
Thanks for suggestions. I've tried to make it more clear.
kontura
reviewed
Feb 28, 2023
CHANGES-DNF-5.md
Outdated
| 1. it allows the solver to skip uninstallable packages to resolve depsolv problems | ||
| 2. it allowd dnf to skip unavailable packages (this is for `install` command mostly) | ||
|
|
||
| The functionality is now splitted to two options - `--skip-broken` for the uninstallable packages and `--skip-unavailable` for packages not present in repositories. |
There was a problem hiding this comment.
I think that while splitted is a word just split would be better.
It's a difference between dnf4 and dnf5 and we should forget to mention it in the docs.
m-blaha
force-pushed
the
mblaha/strict_doc
branch
from
e1c223e to
e207473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a difference between dnf4 and dnf5 and we should forget to mention it in the docs.