PackageQuery: filter_nevra to accept more comparators #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Feb 10, 2023
| libdnf_throw_assert_unsupported_query_cmp_type(cmp_type); | ||
| libdnf_assert_same_base(p_impl->base, package_set.get_base()); | ||
|
|
||
| bool cmp_not = (cmp_type & libdnf::sack::QueryCmp::NOT) == libdnf::sack::QueryCmp::NOT; |
There was a problem hiding this comment.
Minor - to ensure that there is not GT + NOT (or similar) as comperator I would suggest to change the test:
bool cmp_not = (cmp_type == libdnf::sack::QueryCmp::NEQ);
if (cmp_not) {
cmp_type = libdnf::sack::QueryCmp::EQ;
}
There was a problem hiding this comment.
Actually I plan to use LTE + NOT in list command implementation. Let me improve the description of the function.
There was a problem hiding this comment.
I've rephrased the doc string of filter_nevra(PackageSet) filter.
Current implementation of filter_nevra(PackageSet) accepts only EQ and NEQ comparators. This change enhances this filter to accept also GT, GTE, LT, and LTE comparators.
m-blaha
force-pushed
the
mblaha/filter_nevra
branch
from
c53642c to
d95e627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of filter_nevra(PackageSet) accepts only EQ and NEQ comparators.
This change enhances this filter to accept also GT, GTE, LT, and LTE comparators.