Option "disable_multithreading", repo::RepoSack ctors and repo::Repo::fetch_metadata method private, fix/adjust unit tests
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Feb 8, 2023
| repo->load(); | ||
| libdnf::repo::RepoQuery repos(base); | ||
| repos.filter_id(repoid); | ||
| repo_sack->update_and_load_repos(repos); |
There was a problem hiding this comment.
I have a bad feeling about possibility to load subset of repositories using update_and_load_repos(repos). This is not a problem of the PR but our API. The reason is modularity, where it is strongly recommended to have one point of application of modular filtering. The PR is going into right directions.
|
@jrohel May I ask you for checking unit tests, they are failing. |
jrohel
force-pushed
the
RepoSack_ctor_fetch_metadata_private
branch
from
8f2a738 to
353f676
Compare
|
@j-mracek Yes. Unit tests failed. But I hope the problem is not caused by this PR. I think the problem is the persmission change in podman (missing CAP_SYS_CHROOT) and librpm fails during chroot. This PR is a patch for CI tests: rpm-software-management/ci-dnf-stack#1220 |
jrohel
force-pushed
the
RepoSack_ctor_fetch_metadata_private
branch
3 times, most recently
from
fcc85a3 to
a2b9c2b
Compare
jrohel
force-pushed
the
RepoSack_ctor_fetch_metadata_private
branch
6 times, most recently
from
bb204ba to
07c6b16
Compare
jrohel
force-pushed
the
RepoSack_ctor_fetch_metadata_private
branch
from
07c6b16 to
7ce73f6
Compare
It will be used to disable multithreading in libdnf.
jrohel
force-pushed
the
RepoSack_ctor_fetch_metadata_private
branch
from
7ce73f6 to
3e37e98
Compare
jrohel
changed the title
repo::RepoSack ctors and repo::Repo::fetch_metadata method private, fix and adjust unit testsrepo::RepoSack ctors and repo::Repo::fetch_metadata method private, fix/adjust unit tests
jan-kolarik
reviewed
Mar 7, 2023
Single-threaded mode is used when multi-threaded mode is disabled (configuration option "disable_multithreading").
Perl test created a new repo_sack instead of getting the one from base. So for example repo::RepoQuery wouldn't work.
jrohel
force-pushed
the
RepoSack_ctor_fetch_metadata_private
branch
from
3e37e98 to
6145ecc
Compare
jan-kolarik
approved these changes
Mar 8, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepoSack::update_and_load_repos: Added single-threaded mode (used when multi-threaded mode is disabledby configuration option "disable_multithreading".
repo::RepoSackctors andrepo::Repo::fetch_metadatamethod private.RepoSack::update_and_load_reposmethod instead ofrepo::Repo::fetch_metadataandrepo::Repo::load