Display remaining time as nonnegative number #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the time estimates in our progress bars are displayed as negative numbers, e.g: Fedora 42 on Koji 1% [ ] | 4.9 KiB/s | 854.1 KiB | -03h18m This formatting makes sense if the user reads it as "the current time is T minus 3h18m", where T is the time my download will be done. And this is the convention in some contexts, e.g. rocket launches. But it is not idiomatic here, where a user is likely to expect the number to mean "time remaining". Resolves https://bugzilla.redhat.com/show_bug.cgi?id=2332931 Resolves rpm-software-management#1963
Merged
via the queue into
rpm-software-management:main
with commit Jan 2, 2025
8751434
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the time estimates in our progress bars are displayed as negative numbers, e.g:
This formatting makes sense if the user reads it as "the current time is T minus 3h18m", where T is the time my download will be done. And this is the convention in some contexts, e.g. rocket launches. But it is not idiomatic here, where a user is likely to expect the number to mean "time remaining".
Resolves https://bugzilla.redhat.com/show_bug.cgi?id=2332931
Resolves #1963