MultiProgressBar fixes and tests
#1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now every finished progressbar ends with a new line and in non interactive mode only finished progressbars are printed this additional print should never be needed.
Previously the new line was always printed resulting in excessive empty line which was visible for example during the downloading packages phase of an update: ``` [ 1/109] kernel-modules-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 7% [= ] | 781.3 KiB/s | 4.9 MiB | -01m18s [ 2/109] kernel-core-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 8% [== ] | 381.1 KiB/s | 1.5 MiB | -00m45s [ 3/109] kernel-modules-core-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 3% [= ] | 355.8 KiB/s | 1.2 MiB | -01m47s ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ [ 0/109] Total 3% [= ] | 1.5 MiB/s | 7.6 MiB | -02m05s ``` (last line is empty) This was introduced recently in PR rpm-software-management#1805
Since PR rpm-software-management#1825 we are overwriting old output instead of specifically clearing it. This causes problems when messages are removed from progressbars like it happens when scriptlets finish successfully without any logs. Closes: rpm-software-management#1899 Also adds couple describing comments.
This is similar to the `FORCE_COLUMNS` override.
Ensure the tests run in non interactive mode and force columns to 70. It also uses new `ASSERT_MATCH` macro. This simplifies the tests. In addition one test is extended and one new test is added.
In order to be able to compare the outputs it implements `perform_control_sequences` function which simulates a terminal emulator. Since this is a bit complicated there are also specific tests for this testing function.
kontura
force-pushed
the
multiprogressbar
branch
from
a431759 to
df06545
Compare
evan-goode
approved these changes
Dec 4, 2024
m-blaha
approved these changes
Dec 5, 2024
Merged
via the queue into
rpm-software-management:main
with commit Dec 5, 2024
38e5c7e
15 of 17 checks passed
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix couple of issues for
MultiProgressBarprinting.Add testing for
MultiProgressBarin interactive mode.