Skip to content

Drop errorlevel config option #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Drop errorlevel config option #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb2d59d
Drop `errorlevel` config option
kontura Oct 21, 2024
e831f4d
Document dropped `--disableexcludepkgs` option
kontura Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions doc/changes_from_dnf4.7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Changes to individual options
``-d, --debuglevel``
* Dropped. Now only the ``debuglevel`` configuration option is available.

``--disableexcludes``
``--disableexcludes`` and ``--disableexcludepkgs``
* Dropped. Now only the ``disable_excludes`` configuration option is available.

``--disable, --enable``
Expand All @@ -66,7 +66,7 @@ Changes to individual options
* When downloading packages using the ``system-upgrade`` or ``offline`` command, the target path construction now utilizes the configured ``installroot`` and ``cachedir`` options.

``-e, --errorlevel``
* Dropped. Now only the ``errorlevel`` configuration option is available.
* Both the ``--errorlevel`` option and ``errorlevel`` configuration option are dropped.

``--help-cmd``
* Dropped. Now only the ``-h`` or ``--help`` options are available.
Expand Down Expand Up @@ -422,3 +422,6 @@ Dropped configuration options
``arch`` and ``basearch``
* It is no longer possible to change the detected architecute in configuration files.
* See the :manpage:`dnf5-forcearch(7)`, :ref:`Forcearch parameter <forcearch_misc_ref-label>` for overriding architecture.

``errorlevel``
* The option was deprecated in dnf < 5 and is dropped now.
13 changes: 0 additions & 13 deletions doc/dnf5.conf-todo.5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,6 @@ This section does not track any deprecated option. For such options see :ref:`De

Default: ``True``.

.. _errorlevel_options-label:

``errorlevel``
:ref:`integer <integer-label>`

Error messages output level, in the range ``0`` to ``10``. The higher the number the
more error output is put to stderr.

Default: ``3``.

.. WARNING::
This is deprecated in DNF and overwritten by -verbose commandline option.

.. _exit_on_lock_options-label:

``exit_on_lock``
Expand Down
2 changes: 0 additions & 2 deletions include/libdnf5/conf/config_main.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ class LIBDNF_API ConfigMain : public Config {

OptionNumber<std::int32_t> & get_debuglevel_option();
const OptionNumber<std::int32_t> & get_debuglevel_option() const;
OptionNumber<std::int32_t> & get_errorlevel_option();
const OptionNumber<std::int32_t> & get_errorlevel_option() const;
OptionPath & get_installroot_option();
const OptionPath & get_installroot_option() const;
OptionPath & get_config_file_path_option();
Expand Down
9 changes: 0 additions & 9 deletions libdnf5/conf/config_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ class ConfigMain::Impl {
Config & owner;

OptionNumber<std::int32_t> debuglevel{2, 0, 10};
OptionNumber<std::int32_t> errorlevel{3, 0, 10};
OptionPath installroot{"/", false, true};
OptionBool use_host_config{false};
OptionPath config_file_path{CONF_FILENAME};
Expand Down Expand Up @@ -300,7 +299,6 @@ class ConfigMain::Impl {

ConfigMain::Impl::Impl(Config & owner) : owner(owner) {
owner.opt_binds().add("debuglevel", debuglevel);
owner.opt_binds().add("errorlevel", errorlevel);
owner.opt_binds().add("installroot", installroot);
owner.opt_binds().add("use_host_config", use_host_config);
owner.opt_binds().add("config_file_path", config_file_path);
Expand Down Expand Up @@ -474,13 +472,6 @@ const OptionNumber<std::int32_t> & ConfigMain::get_debuglevel_option() const {
return p_impl->debuglevel;
}

OptionNumber<std::int32_t> & ConfigMain::get_errorlevel_option() {
return p_impl->errorlevel;
}
const OptionNumber<std::int32_t> & ConfigMain::get_errorlevel_option() const {
return p_impl->errorlevel;
}

OptionPath & ConfigMain::get_installroot_option() {
return p_impl->installroot;
}
Expand Down
Loading