Recommend --use-host-config if --installroot is used and not all repositories can be enabled #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitories can be enabled
It was reported that --installroot with an explicit --repo option
does not recognize given repository despite the repository is defined
under /etc:
$ dnf --installroot /tmp/dnf5/ --releasever rawhide --repo koji makecache
No matching repositories for "*, koji". Add "--help" for more information about the arguments.
That's a feature, but a difference from DNF4.
This patchs recommeds using --use-host-config in that case. We already
have a similar recommendation in main.cpp in case of no --repo option is used.
This patch also fixes formatting of the list of repository
identifiers with respect to localization.
The code duplicates throws because libdnf5 exception construtors do
not accept nonstatic arguments.
Resolves rpm-software-management#1756
|
The formatting errors were fixed by #1762. They are not related to this PR. |
|
This patch changes a text of an error message and thus these tests needs to adjust: @kontura, are you fine with the new error message? If so, I will change the tests. |
kontura
approved these changes
Oct 9, 2024
ppisar
added a commit
to ppisar/ci-dnf-stack
that referenced
this pull request
Oct 9, 2024
…sitories can be enabled Adpapt tests to a new error message wording when an installroot is used and a repository cannot be enabled or disabled. Related: rpm-software-management/dnf5#1760
ppisar
added a commit
to ppisar/ci-dnf-stack
that referenced
this pull request
Oct 9, 2024
…sitories can be enabled Adapt tests to a new error message wording when an installroot is used and a repository cannot be enabled or disabled. Related: rpm-software-management/dnf5#1760
|
Thank you. |
Merged
via the queue into
rpm-software-management:main
with commit Oct 9, 2024
b977f59
13 of 20 checks passed
kontura
pushed a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Oct 9, 2024
…sitories can be enabled Adapt tests to a new error message wording when an installroot is used and a repository cannot be enabled or disabled. Related: rpm-software-management/dnf5#1760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that --installroot with an explicit --repo option does not recognize given repository despite the repository is defined under /etc:
That's a feature, but a difference from DNF4.
This patchs recommeds using --use-host-config in that case. We already have a similar recommendation in main.cpp in case of no --repo option is used.
This patch also fixes formatting of the list of repository identifiers with respect to localization.
The code duplicates throws because libdnf5 exception construtors do not accept nonstatic arguments.
Resolves #1756