Allow unlimited number of arguments for history list and info
#1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a better user experience to first verify the arguments and only then do any other actions such as creating directories or asking for confirmation.
This code is also used for other `history` commands but they do their own checking for number of selected transactions (because it is possible to select multiple transaction with just one argument). Closes: rpm-software-management#1721
|
I noticed that the tests for |
m-blaha
approved these changes
Oct 4, 2024
Never mind, I'm blind and you already have PR for it. Sorry for the noice. |
Merged
via the queue into
rpm-software-management:main
with commit Oct 4, 2024
2594423
17 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow unlimited number of arguments for history
listandinfoCloses: dnf history list and dnf history info do not accept multiple arguments #1721
history storecommand: move arg verificion above user confirmation