Skip to content

Enable packit copr-builds and testing #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

Enable packit copr-builds and testing #2249

merged 3 commits into from
Jun 20, 2025

Conversation

@kontura
Copy link
Contributor

@kontura kontura commented Jun 13, 2025

No description provided.

@kontura kontura requested a review from a team as a code owner June 13, 2025 07:11
@kontura kontura requested review from dcantrell and removed request for a team June 13, 2025 07:11
@kontura
Copy link
Contributor Author

kontura commented Jun 13, 2025

/packit test rpm-software-management/libdnf#1711

@kontura
Copy link
Contributor Author

kontura commented Jun 13, 2025

/packit build rpm-software-management/libdnf#1711

@kontura
Copy link
Contributor Author

kontura commented Jun 16, 2025

/packit build

@kontura
Copy link
Contributor Author

kontura commented Jun 16, 2025

/packit test

dcantrell
dcantrell requested changes Jun 17, 2025
View reviewed changes
@kontura
Copy link
Contributor Author

kontura commented Jun 18, 2025

Regarding the failing tests:

  1. The fedora-rawhide fails are valid and we should look into them but it is not connected to this PR. I have also filed an issue for them some time ago: Failing dnf-4-stack copr rawhide tests dnf-plugins-core#592 (it is on the ci-dnf-stack because I believe the problem likely is in the test).
  2. For the centos-stream-9 builds I don't understand why they fail. They were failing even before this PR but adding the nightly repo should have fixed them. Looking into the logs I don't understand why it tries to install old libdnf-0.75.0-0.20250613011536.0.74.0+14.g22a11eee.el9.x86_64 which has a missing associated librepo build when there are new builds (for example from yesterday) that work and there is a librepo build.
    I cannot reproduce the fail in a centos-stream-9 container. To me it seems like the packit copr build doesn't see updated nightly repository but it sees only a version from 2025.06.13.

@ppisar ppisar mentioned this pull request Jun 19, 2025
Merged
@ppisar
Copy link
Contributor

ppisar commented Jun 19, 2025

The changes look good.

One thing I don't understand: HowePackit knows where to take builds for testing. Does "job: tests" expect builds in the immediately preceding "job: copr_build"? Otherwise, I don't understand why the two "job: copr_build" YAML subtrees cannot be merged into one with multiple "targets" items.

@ppisar
Copy link
Contributor

ppisar commented Jun 19, 2025

One thing I don't understand: HowePackit knows where to take builds for testing. Does "job: tests" expect builds in the immediately preceding "job: copr_build"? Otherwise, I don't understand why the two "job: copr_build" YAML subtrees cannot be merged into one with multiple "targets" items.

https://packit.dev/docs/configuration/upstream/tests does not explicitly states it, but it seems probable that builds from all "job: copr_build" are used for all "job: tests" and they are paired automatically by a target.

@kontura
Copy link
Contributor Author

kontura commented Jun 19, 2025

Right, I also think it can be just one copr_build job.
I have already merged them.

It just didn't occur to me.

ppisar
ppisar reviewed Jun 19, 2025
View reviewed changes
@ppisar
Copy link
Contributor

ppisar commented Jun 19, 2025 

2. For the centos-stream-9 builds I don't understand why they fail. They were failing even before this PR but adding the nightly repo should have fixed them. Looking into the logs I don't understand why it tries to install old `libdnf-0.75.0-0.20250613011536.0.74.0+14.g22a11eee.el9.x86_64` which has a missing associated librepo build when there are new builds (for example from yesterday)  that work and there is a librepo build.

I have replaced centos-stream-9 target with centos-stream+epel-next-9 in dnf-nightly configuration because dnf-plugin-extras needs rpmconf which is only in EPEL. Do packit targets need to match dnf-nightly Copr targets?

kontura added 2 commits June 20, 2025 06:00
@kontura
Enable packit copr-builds and testing
6c91efe 
It includes dnf-nightly because when we increase the minimal required
version it might not be released yet.
@kontura
Add nightly to bootc tests
b432aba 
It it likely needed here even more because the centos builds are not
updated as frequently as fedora builds.
@ppisar
Copy link
Contributor

ppisar commented Jun 20, 2025

I have replaced centos-stream-9 target with centos-stream+epel-next-9 in dnf-nightly configuration because dnf-plugin-extras needs rpmconf which is only in EPEL. Do packit targets need to match dnf-nightly Copr targets?

copr_build job works with centos-stream+epel-next-9 but tests job does not know that name:

The compose CentOS-Stream+Epel-Next-9 is not available in the public Testing Farm infrastructure.

The compose CentOS-Stream+Epel-Next-9 (from target centos-stream+epel-next-9) does not match any compose in the list of available composes:
{'CentOS Stream .+', 'Fedora-Rawhide', 'Fedora-latest-aarch64', 'debezium-tf-\d+(:?-xs)?$', 'CentOS-Stream-10', 'CentOS-Stream-8-aarch64', 'Fedora-Cloud-Base-.+', 'CentOS-Stream-9', 'CentOS-Stream-10-image-mode', 'CentOS-Stream-8', 'Fedora-Rawhide-image-mode', 'auto-.', 'CentOS-7', 'CentOS-Stream-9-image-mode', 'debezium-tf-1930', 'Fedora-Rawhide-aarch64', 'debezium-tf-1930-xs', 'Fedora-41', 'composer-.', 'Fedora-42', 'Fedora-42-image-mode', 'CentOS-7-aarch64', 'debezium-tf-2130', 'Fedora-eln', 'Fedora-40-image-mode', 'Fedora-41-image-mode', 'Fedora-latest', 'debezium-tf-2130-xs', 'Fedora-40', 'CentOS-Stream-9-aarch64'}.

Obviously they are of different kind and TMT does not recognize it.

I recommend opening a bug against Packit.

If you want, you can change a target for dnf-bootc-tests back to "centos-stream-9-x86_64", while keeping a target for copr_build as it is. Otherwise, I will merge this pull request as it is.

@kontura
Switch centos-stream-9-x86_64 copr-builds to `centos-stream+epel-ne…
b363347 
…xt-9-x86_64`

This is required because rpmsoftwaremanagement/dnf-nightly switched to
it as well.

We keep the `tests` job as `centos-stream-9-x86_64` because `Testing
Farm` doesn't recognize `centos-stream+epel-next-9-x86_64`.
@kontura
Copy link
Contributor Author

kontura commented Jun 20, 2025

If you want, you can change a target for dnf-bootc-tests back to "centos-stream-9-x86_64", while keeping a target for copr_build as it is. Otherwise, I will merge this pull request as it is.

That is a good idea, lets try that.
However if that doesn't work I agree with merging, this PR really isn't about the not-working bootc tests.

@ppisar ppisar merged commit b1a44be into rpm-software-management:master Jun 20, 2025
6 of 9 checks passed
@ppisar
Copy link
Contributor

ppisar commented Jun 20, 2025

That's funny. The "tests" job for a target missing from "copr_build" job simply synthesized and executed a matching copr_build job.

@kontura kontura mentioned this pull request Jun 23, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcantrell dcantrell dcantrell approved these changes

@ppisar ppisar ppisar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kontura @ppisar @dcantrell