Add several tests for check-upgrade with advisories and minimal options #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
requested changes
Jun 5, 2024
| @@ -55,6 +98,15 @@ Scenario: upgrade-minimal sec-severity | |||
| | Action | Package | | |||
| | upgrade | advisory_B-0:1.0-2.x86_64 | | |||
|
|
|||
| Scenario: check-upgrade --minimal with sec-severity | |||
| When I execute dnf4 with args "upgrade-minimal --sec-severity Moderate" | |||
There was a problem hiding this comment.
I believe the I execute dnf4 step shouldn't be here, it is not being run, it is a wrong command and these tests are only for dnf5.
There was a problem hiding this comment.
Thank you - I've replaced dnf4 and dnf5 by simple dnf
| @@ -64,6 +116,15 @@ Scenario: upgrade-minimal with pkgs specified sec-severity | |||
| | Action | Package | | |||
| | upgrade | advisory_B-0:1.0-2.x86_64 | | |||
|
|
|||
| Scenario: check-upgrade --minimal with pkgs specified sec-severity | |||
| When I execute dnf4 with args "upgrade-minimal advisory_B --sec-severity Moderate" | |||
There was a problem hiding this comment.
I believe the I execute dnf4 step shouldn't be here, it is not being run, it is a wrong command and these tests are only for dnf5.
j-mracek
force-pushed
the
advisories-minimal
branch
from
2ff2341 to
47885c7
Compare
Some of the tests are related to new option --minimal for check-upgrade
j-mracek
force-pushed
the
advisories-minimal
branch
from
47885c7 to
7e73511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests are related to new option --minimal for check-upgrade