Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement instance_destroy based on copy-on-write entity lists #46

Merged
merged 2 commits into from
May 23, 2020

Conversation

rpjohnst
Copy link
Owner

@rpjohnst rpjohnst commented May 23, 2020

This addresses the with problems described in #40.

Entity lists are now copy-on-write. This lets the interpreter keep
iterators pointing into them while (potentially) mutating them, and
preserves GML `with` semantics in the presence of such mutation.

In particular, this makes `instance_create` and `instance_destroy` memory
safe when called from GML, as described by #40.
@rpjohnst rpjohnst merged commit be4f276 into master May 23, 2020
@rpjohnst rpjohnst deleted the iterators branch May 23, 2020 23:11
@rpjohnst rpjohnst mentioned this pull request May 23, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant