Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings.json to use new rust-analyzer.check.allTargets #86

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Update settings.json to use new rust-analyzer.check.allTargets #86

merged 1 commit into from
Nov 3, 2024

Conversation

axelkar
Copy link
Contributor

@axelkar axelkar commented Oct 15, 2024

@jannic
Copy link
Member

jannic commented Oct 15, 2024

Thanks for your contribution. I don't know much about rust analyzer config, so I'll have to read the docs / try it out before approving this. Great that you provided a link to the corresponding change to rust-analyzer!
(Of course, if some reviewer with more knowledge about rust analyzer is sure that this is fine, feel free to approve & merge!)

9names
9names approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old option is still accepted, but since this was changed 2 years ago I think we're pretty safe moving to the new syntax.
It's unlikely to be removed any time soon but waiting until it is deprecated is also sub-optimal.
LTGM

@9names 9names merged commit c910b1f into rp-rs:main Nov 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9names 9names 9names approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axelkar @jannic @9names