Skip to content

FibSUM.cpp#20

Merged
ultrathlete merged 3 commits intoroyalpranjal:masterfrom
CodeLogist:patch-1
Oct 18, 2018
Merged

FibSUM.cpp#20
ultrathlete merged 3 commits intoroyalpranjal:masterfrom
CodeLogist:patch-1

Conversation

@CodeLogist
Copy link
Contributor

This one is with Better Space and Time complexity with not extra variable space or Vector. Please have a Look

This one is with Better Space and Time complexity with not extra variable space or Vector. Please have a Look
@ultrathlete
Copy link
Collaborator

That's utterly wrong. Read the problem statement again.

This may Be Easier for the People to understand and implement with same complexity of yours
@ultrathlete
Copy link
Collaborator

I believe you copied the code from here. I would not encourage copying and making pull requests, but if @royalpranjal doesn't have any problem, then your solution is good to go except changing 'tahn' to 'than' in this line. The OP has this mistake in his code which reminded me of the same when I saw your code.

@CodeLogist
Copy link
Contributor Author

No absolutely not.. I too support git family standards and would never go for copying. Actually the same question was tough by one of my mentor so I did it that way. And about the mistake in 'tahn' that may by my typo mistake... I'll make it correct thanks for seeing that

@royalpranjal
Copy link
Owner

The code looks fine but it doesn't follow the InterviewBit function template. Can you update the snippet according to the InterviewBit norm ?

@CodeLogist
Copy link
Contributor Author

The interviewBit code panel and online judge also accepted it so i think it does follow the function template. If it my code really needs some changes then, can make it too, theirs no prob at all.

@ultrathlete ultrathlete merged commit f5af9d3 into royalpranjal:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants