Allow sorting by atime and ctime as well as mtime. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the new sort types, this also adds atime and ctime columns to the list view -- which makes sense, given that the details view shows atime/ctime when times are shown. I've kept mtime first because it's the one you're most likely to be interested in. For consistency, it would make sense to rename "Sort by Date" to "Sort by Last Modified" (and SORT_DATE to SORT_MTIME), but that would need changes to all the translations too.
This means we're consistent with the "mtime, atime, ctime" order everywhere.
... and SORT_DATE to SORT_MTIME. List View already called this column "Last Modified", so this means the terminology is consistent between the views, although it'll need changes to the translations. Backwards compatibility: the numeric value of the option is the same, so existing Options files will still work, and remote mode accepts "Date" to mean the same as "LastModified".
|
I did finally find a use for sort-by-atime a couple of weeks ago, so it's not completely useless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often want to sort by ctime. (I'm not sure how useful atime is... but "with Times" did show it already.)
The changes are straightforward enough, but I'm a bit antsy about the impact this has on the translations, hence the split commits to optionally keep "Sort by Date" intact.