Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pinboard/panel icon name from .desktop files. #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dtomas
Copy link

@dtomas dtomas commented Mar 16, 2015

When dropping a .desktop file to the panel/pinboard, set the icon's name to the .desktop file's "Name" entry.


icon->item = diritem_new(name);
diritem_restat(icon->path, icon->item, NULL);

if (icon->item->mime_type == application_x_desktop)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to free the old leafname here?

@ruigazio
Copy link

And 5 years later this PR (and others) haven't been merged. Is the project orphaned?

@dodona2
Copy link

dodona2 commented Dec 15, 2020

And 5 years later this PR (and others) haven't been merged. Is the project orphaned?

I think so.

@frankzen
Copy link

There are updated repositories of others who have updated and maintained Rox.
such as: https://github.com/jun7/rox-filer
and : https://gitlab.com/seirios/rox-filer
Both are miles ahead of this one. Unfortunate, but true.

@dodona2
Copy link

dodona2 commented Dec 16, 2020

There are updated repositories of others who have updated and maintained Rox.
such as: https://github.com/jun7/rox-filer
and : https://gitlab.com/seirios/rox-filer
Both are miles ahead of this one. Unfortunate, but true.

look at the time stamps. 2 - 18 years old sources. They might be orphaned too.

@frankzen
Copy link

There are updated repositories of others who have updated and maintained Rox.
such as: https://github.com/jun7/rox-filer
and : https://gitlab.com/seirios/rox-filer
Both are miles ahead of this one. Unfortunate, but true.

look at the time stamps. 2 - 18 years old sources. They might be orphaned too.

Don't worry about the timestamps....the software has been and is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants