Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes label not displayed in Status type #1241

Merged
merged 3 commits into from
May 4, 2023
Merged

Fixes label not displayed in Status type #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5708153
Update CONTRIBUTING.md
harinij May 2, 2023
60d4213
Fix label not showing in status type
alceil May 3, 2023
9c6bae2
Merge branch 'develop' into status-bug-fix
shamsmosowi May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ Read the documentation on setting up your local development environment
Read how to submit a pull request [here](https://docs.rowy.io/contributing).

To get familiar with the project,
[good first issues](https://github.com/rowyio/rowy/projects/3) is a good place
[good first issues](https://github.com/rowyio/rowy/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) is a good place
to start.

## Working on existing issues


Before you get started working on an
[issue](https://github.com/rowyio/rowy/issues), please make sure to share that
you are working on it by commenting on the issue and posting a message on
Expand All @@ -38,6 +39,7 @@ assigned to you, then we will assume you have stopped working on it and we will
unassign it from you - so that we can give a chance to others in the community
to work on it.


## File a feature request

If you have some interesting idea that will be a good addition to Rowy, then
Expand All @@ -46,7 +48,7 @@ create a new issue using
to share your idea. If you are working on this to contribute to the project,
then let others in the community and project maintainers know by posting on
#contributions channel in Rowy's
[Discord](https://discord.com/invite/fjBugmvzZP). This allows others in the
[Discord](https://rowy.io/discord). This allows others in the
community and the maintainers a chance to provide feedback and guidance before
you spend time working on it.

Expand Down
2 changes: 1 addition & 1 deletion src/components/fields/Status/utils/getLabelHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function getLabel(value: any, conditions: any) {
let _label: any = undefined;
const isBoolean = Boolean(typeof value === "boolean");
const notBoolean = Boolean(typeof value !== "boolean");
const isNullOrUndefined = Boolean(!value && notBoolean);
const isNullOrUndefined = Boolean((value === null || value === undefined) && notBoolean);
const isNumeric = Boolean(typeof value === "number");

if (isNullOrUndefined) _label = getFalseyLabelFrom(conditions, value);
Expand Down