Skip to content

Commit

Permalink
Merge pull request #1241 from alceil/status-bug-fix
Browse files Browse the repository at this point in the history
Fixes label not displayed in Status type
  • Loading branch information
shamsmosowi authored May 4, 2023
2 parents e33969f + 9c6bae2 commit fe816fc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ Read the documentation on setting up your local development environment
Read how to submit a pull request [here](https://docs.rowy.io/contributing).

To get familiar with the project,
[good first issues](https://github.com/rowyio/rowy/projects/3) is a good place
[good first issues](https://github.com/rowyio/rowy/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) is a good place
to start.

## Working on existing issues


Before you get started working on an
[issue](https://github.com/rowyio/rowy/issues), please make sure to share that
you are working on it by commenting on the issue and posting a message on
Expand All @@ -38,6 +39,7 @@ assigned to you, then we will assume you have stopped working on it and we will
unassign it from you - so that we can give a chance to others in the community
to work on it.


## File a feature request

If you have some interesting idea that will be a good addition to Rowy, then
Expand All @@ -46,7 +48,7 @@ create a new issue using
to share your idea. If you are working on this to contribute to the project,
then let others in the community and project maintainers know by posting on
#contributions channel in Rowy's
[Discord](https://discord.com/invite/fjBugmvzZP). This allows others in the
[Discord](https://rowy.io/discord). This allows others in the
community and the maintainers a chance to provide feedback and guidance before
you spend time working on it.

Expand Down
2 changes: 1 addition & 1 deletion src/components/fields/Status/utils/getLabelHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function getLabel(value: any, conditions: any) {
let _label: any = undefined;
const isBoolean = Boolean(typeof value === "boolean");
const notBoolean = Boolean(typeof value !== "boolean");
const isNullOrUndefined = Boolean(!value && notBoolean);
const isNullOrUndefined = Boolean((value === null || value === undefined) && notBoolean);
const isNumeric = Boolean(typeof value === "number");

if (isNullOrUndefined) _label = getFalseyLabelFrom(conditions, value);
Expand Down

0 comments on commit fe816fc

Please sign in to comment.