Otel integration #17
Merged
Otel integration #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliorenner
reviewed
Mar 2, 2023
core/src/main/java/com/netflix/conductor/core/events/SimpleActionProcessor.java
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/core/tracing/Tracing.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/core/config/TracingProperties.java
Show resolved
Hide resolved
juliorenner
approved these changes
Mar 13, 2023
| public Optional<String> getTraceId() { | ||
| if (this.span.isPresent()) { | ||
| SpanContext spanContext = this.span.get().getSpanContext(); | ||
| return Optional.of( |
There was a problem hiding this comment.
weird that we have to manually generate the traceID, isn't it provided in the span context?
There was a problem hiding this comment.
the SpanContext only provided methods to access only the parts of the full trace id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize tracing in a separate bean so the tracing instance can be injected into the contrib libraries