new option for configurable cookie lifetime

[emtiu]

Implementing #5050 by introducing a new config option cookie_lifetime.

The default is the current behavior (i.e. set session cookies with lifetime 0).

[emtiu]

Just an update to confirm that this feature works as expected in long-time, real-world conditions: I've set session_lifetime to 3 days and cookie_lifetime to 30 days.

Now, any browser that opens Roundcube at least every 3 days will only need to re-login once every 30 days. However, if 3 days pass without opening Roundcube, the session expires, and a the browser needs to login again, starting another 3 day/30 day timeout.

[emtiu]

With this going nowhere, I'm maintaining a patch for this functionality in its own repository.

//cc #5050 #7251 #7865 @mkllnk @HighlyFavoredBA

[alecpl]

I don't like how it is. The cookie_lifetime should be always 0. Then the user can opt-in to make it longer by checking "remember me" checkbox on the logon screen. Whether to display the checkbox and what is the cookie_lifetime in this mode could be controlled by a config option.

[bsdice]

@emtiu Thanks very much for the patch, using it on my private RC.

[DoobleD]

I'd like that option too. A remember me could work sure but if I'm not mistaken it requires finding and installing some remember me plugin, which may not be well maintained. In comparison the cookie_lifetime option is simple and works out of the box.

[Github-Citizen]

I don't like how it is. The cookie_lifetime should be always 0. Then the user can opt-in to make it longer by checking "remember me" checkbox on the logon screen. Whether to display the checkbox and what is the cookie_lifetime in this mode could be controlled by a config option.

I know this is old, but what "remember me" check box on login screen? I have never seen one. Is this a setting that must be enabled?

[emtiu]

I know this is old, but what "remember me" check box on login screen? I have never seen one. Is this a setting that must be enabled?

No, it's a proposed alternative solution that doesn't exist.

[twekkel]

I know this is old, but what "remember me" check box on login screen? I have never seen one. Is this a setting that must be enabled?

No, it's a proposed alternative solution that doesn't exist.

Well, this plugin has that check box for "remember me" functionality,
https://github.com/mfreiholz/persistent_login

but it has to maintain a separate table (auth_tokens) which almost duplicates the standard sessions table in roundcube.

A checkbox on the login screen that enables a user to toggle between a (per user) 'session_lifetime' = 10 (default) or e.g. 10000 (~week) would do the trick... right?

[calbearox]

@maldito-dot

[DoobleD]

Any update on this? Still interested in having this merged here, applying the patch manually for now.

[Neustradamus]

Any progress on this PR?

[emtiu]

Any progress on this PR?

Nothing since it was informally rejected here in 2021.

But I'm keeping my patches up to date with every release of Roundcube 😇

[bsdice]

Also still using @emtiu 's patches, ported to 1.7.0. I just think I hit a documentation issue:

"Note that whatever the cookie_lifetime set for the browser, sessions always expire after closing Roundcube when the session_lifetime (as tracked by the server) has expired. Therefore, it makes no sense to set a cookie_lifetime longer than the session_lifetime."

And later: "cookie_lifetime set to 14 days, session_lifetime set to 2 days: Any browser that logs in to Roundcube stays logged in for 14 days at most, but is logged out automatically after 2 days have passed without opening Roundcube. --> If Roundcube is accessed at least every 2 days, the user will only need to re-login every 14 days."

Isn't that a contradiction?

[emtiu]

Isn't that a contradiction?

You're right! Thank you for pointing this out, I've fixed the description 👍

[pferreir]

Hi there! Can we have this as core functionality, somehow?

[pabzm]

Nothing since it was informally rejected here in 2021.

From my understanding this PR might have a chance if the extended cookie lifetime would depend on a "remember me"-checkbox at the login.

@alecpl Is that correct?

@emtiu Would you be willing to change the code accordingly?

[emtiu]

@emtiu Would you be willing to change the code accordingly?

Thanks for the suggestion. I'm afraid I don't have the time to figure out how to do that, and the current patch already does what I want it to do.

[melroy89]

I don't like how it is. The cookie_lifetime should be always 0. Then the user can opt-in to make it longer by checking "remember me" checkbox on the logon screen. Whether to display the checkbox and what is the cookie_lifetime in this mode could be controlled by a config option.

Which "remember me" checkbox?

[emtiu]

Which "remember me" checkbox?

See this reply: There is no such checkbox. It's a proposed alternative solution that doesn't exist.

[Github-Citizen]

I created a plugin in 2022 to add the checkbox since it was never done. Feels like it should be a built in feature. However the PR was declined because the authors didn't like my "coding style".

https://github.com/roundcube/roundcubemail/pull/8689/files

[melroy89]

I created a plugin in 2022 to add the checkbox since it was never done. Feels like it should be a built in feature. However the PR was declined because the authors didn't like my "coding style".

https://github.com/roundcube/roundcubemail/pull/8689/files

Thanks. While a good coding style is important for a large project like this. I do expect there is some kind of tools to help you. Like a good one is PHP CS fixer. Maybe Roundcube could embrace PHP-CS-fixer in order to fix the coding styles issues automatically (whenever possible). They already have it: https://github.com/roundcube/roundcubemail/blob/master/.php-cs-fixer.dist.php