Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for deprecated Ruby versions #1694

Closed
tancnle opened this issue Mar 23, 2021 · 4 comments
Closed

Drop support for deprecated Ruby versions #1694

tancnle opened this issue Mar 23, 2021 · 4 comments
Labels
enhancement-request A request for an enhancement to be developed. stale-issue There has been no activity for a year.

Comments

@tancnle
Copy link
Collaborator

tancnle commented Mar 23, 2021

Description

With Ruby 2.4 EOL (https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/), we should drop support for old versions to reduce Rouge gem maintenance effort. It also helps to reduce build runtime and avoid overrunning our monthly CI build time allotment.

Proposal

  • Update README and gemspec to indicate this change
  • Remove Ruby 2.4 and below from CI pipelines (i.e. .travis.yml)
  • Update Rubocop to target Ruby 2.5 (i.e. rubocop.yml)
  • Mark this change for a minor version bump
@tancnle tancnle added the enhancement-request A request for an enhancement to be developed. label Mar 23, 2021
@tancnle
Copy link
Collaborator Author

tancnle commented Mar 23, 2021

/cc @dblessing as discussed.

@dblessing
Copy link
Collaborator

Thanks @tancnle. I agree with only supporting 2.5+

@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Nov 2, 2022
@tancnle
Copy link
Collaborator Author

tancnle commented Dec 16, 2022

Resolved by #1862

@tancnle tancnle closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement-request A request for an enhancement to be developed. stale-issue There has been no activity for a year.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants