Drop support for Ruby < 2.4 #1695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me |
tancnle
force-pushed
the
drop-ruby-2-4-support
branch
from
49409be
to
4619b06
Compare
With Ruby 2.4 being EOL, we should drop support for old versions to reduce Rouge gem maintenance effort.
tancnle
force-pushed
the
drop-ruby-2-4-support
branch
from
4619b06
to
272eb0c
Compare
Since only Ruby 2.5 and above are supported, we can remove gem installation base on old Ruby versions.
With Ruby 2.0 being dropped, we do not need to support older versions.
|
Closed in favour of #1862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Ruby 2.4 being EOL, we should drop support for old versions to reduce Rouge gem maintenance effort. It also helps to reduce build runtime and avoid overrunning our monthly CI build time allotment.
Closes #1694