Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility upgrade #657

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Accessibility upgrade #657

merged 2 commits into from
Mar 25, 2021

Conversation

LuckyDucko
Copy link
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR introduces a new feature, the AndroidTalkbackAccessibilityWorkaround (I'm okay with a name change however)

This will include a docs update that is required

⤵️ What is the current behavior?

The current behaviour is shown in #585 where unfortunately, talkback seems to focus on background areas. This seems to be not directly this plugins fault, as others have noted that this seems to be intended behaviour

This is why I have named this a workaround, as it is intended to provide more meaningful results to talkback when popups are involved.

🆕 What is the new behavior (if this is a feature change)?

The new behaviour is that only the popup, and views within it, are 'seen' by the talkback

💥 Does this PR introduce a breaking change?

Not that I am aware of.

🐛 Recommendations for testing

Within #585 a sample project is provided showcasing the issue, I recommend adding a reference to this branch to this project, and testing that way.

_Please note, i don't have my android device on me right now while making this PR, but I didn't want this work to be left out and forgotten about. I have not tested if my AndroidWorkaround setting itself works, however, I have tested the functionality assuming it is always on and it worked perfectly. _

📝 Links to relevant issues/docs

#585

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated --THIS WILL BE DONE ONCE MERGED
  • Rebased onto current develop

…und within each page for android.

Added the example usage in LoginPopupPage
@LuckyDucko
Copy link
Collaborator Author

@martijn00 can you have a look over this and give some advice if I'm heading down the right direction?

It seems a bit hacky, having a special android only variable which forces android devices to work as expected with TalkBack. However, looking at the issue #585 it clearly is in demand

@uday-lucky
Copy link

Thanks @LuckyDucko for the fix 👍 👍 👍 . I wish it will fix the issue. @martijn00 , could you please have a look on this?. We are using rg.plugins.popup in multiple xamarin projects, facing the accessibility issue in android. eagerly waiting for this issue to be solved. Thanks.

@martijn00
Copy link
Collaborator

Let's go for this for now. If there is something later that works beter we can replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants