Skip to content

Commit

Permalink
Merge pull request #234 from rotorgames/develop
Browse files Browse the repository at this point in the history
Merge branch 'develop'
  • Loading branch information
rotorgames authored Feb 4, 2018
2 parents 793a6c8 + e88df68 commit 25bccb8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ Or in xaml

### Doesn't work/build or etc
* Check if one version of plugin has been installed to an each project with Xamarin.Forms in solution.
* Check you open popup pages only in a main thread.
* Check you use `await` operator for pushing and popping popup pages.
* Clean a solution or an each Xamarin.Forms project.
* Close Visual Studio (or VS for Mac or Xamarin Studio or other IDA) and remove an each obj and bin folder in the each project.
* If previous items didn't help, don't hesitate, [create a new issue here](https://github.com/rotorgames/Rg.Plugins.Popup/issues).
Expand Down
4 changes: 3 additions & 1 deletion nuspec/Rg.Plugins.Popup.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
<iconUrl>https://raw.githubusercontent.com/rotorgames/Rg.Plugins.Popup/master/icons/icon.png</iconUrl>
<licenseUrl>https://github.com/rotorgames/Rg.Plugins.Popup/blob/master/LICENSE.md</licenseUrl>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<description>Plugin for Xamarin forms. Allows you to open any page as a popup.</description>
<description>Plugin for Xamarin forms. Allows you to open any page as a popup.

Release Notes: https://github.com/rotorgames/Rg.Plugins.Popup/releases</description>
<tags>Xamarin.Forms xamarin forms popup page modal</tags>
<dependencies>
<dependency id="Xamarin.Forms" version="2.5.0.121934" />
Expand Down
4 changes: 2 additions & 2 deletions src/Rg.Plugins.Popup.Droid/Impl/PopupPlatformDroid.cs
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,14 @@ private bool GetIsSystemAnimationEnabled()
animationScale = Settings.Global.GetFloat(
context.ContentResolver,
Settings.Global.AnimatorDurationScale,
0);
1);
}
else
{
animationScale = Settings.System.GetFloat(
context.ContentResolver,
Settings.System.AnimatorDurationScale,
0);
1);
}

return animationScale > 0;
Expand Down

2 comments on commit 25bccb8

@JaeWLee
Copy link

@JaeWLee JaeWLee commented on 25bccb8 Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guys, why you don't release stable version?? not pre

@rotorgames
Copy link
Owner Author

@rotorgames rotorgames commented on 25bccb8 Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaeWLee Hi. I can't do it because I'm waiting for when xamarin/Xamarin.Forms#1757 is merged. It allows me to create an android back button handler without a reflection. If I publish a stable version a lot of people will open issues and will write me about problems. I hope that xamarin's contributors will merge it to the stable xamarin forms release soon.

Please sign in to comment.