Nested Factories #119
Open
Nested Factories #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add to the capability of `extend` by adding a second parameter, which is the name of an attribute to add this factory under - Adds `attribute__childAttr` attributes to parent - Adds `attribute__childOption` options to parent - Removes `attribute__childAttr`s from the resulting output object - Retains the old behavior if no attribute is given - Add quite a few tests to ensure that it works - Add documentation in the readme with examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find myself writing this code out in my codebase, so I figured I would attempt to contribute back. We've found it to be a huge timesaver for us, especially in terms of large nested objects, with large, nested component trees.
The main purpose is to be able to extend a factory as a nested factory easily (
ParentFactory.extend(ChildFactory, 'child')) and be able to pass attributes and options for children easily into the parent factory. I settled on the double underscore convention (child__childAttr), as dot notation got messy, and nested objects conflicted with the ability to pass in attributes.In addition to using this frequently in my own (unfortunately proprietary) codebase, I've also written tests here, and updated the readme. Please let me know if you need me to make any other adjustments.