Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using composer .. #1

Closed
S1SYPHOS opened this issue Apr 14, 2018 · 3 comments
Closed

Using composer .. #1

S1SYPHOS opened this issue Apr 14, 2018 · 3 comments

Comments

@S1SYPHOS
Copy link

.. would be great!

@rosell-dk
Copy link
Owner

not sure how to do that the best way.
The plugin itself is not going to be installed with composer, but through the Wordpress installer. The vendor libraries will have to be part of the plugin.

It would perhaps be nice development-wise to be able to update the vendor libraries with composer. On the other hand, I do not want to have to release new versions of the vendor libraries in order to use it here. Perhaps github submodule would be a better choice here.

Right now, I simply copy files over, when I change the dependent libraries. I could improve that process with a rsync script.

@marko-stimac
Copy link

You can use https://wpackagist.org to install Wordpress plugins, it works nice 👍

@rosell-dk
Copy link
Owner

The plugin here on github now uses composer. I still include the vendor files on the svn. It is probably best so.

For the few, who might be using this thing here on github: To get the dependent libraries, you need to cd into the plugin dir and run composer update. This gets you the latest dev releases of "webp-convert" and "webp-convert-cloud-service" on github. You must change the composer.json if you rather want the latest stable release (remove the repositories and change the minimum requirements). On the svn, I simply rsync everything, including the vendor folder, before committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants