feat: add vim mode indicator colors - #27
Merged
ThatOneCalculator merged 1 commit intoJun 12, 2026
Merged
Conversation
Zed's per-mode vim indicator colors (vim.<mode>.background/.foreground) default to transparent, so the mode indicator rendered as plain muted text instead of a colored pill. Set them across all three variants: Normal=foam, Insert=pine, Replace=love, Visual/Line/Block=iris, with $base as the foreground so text stays readable on dark and light. Regenerated themes/ from src/template.json via @rose-pine/build.
thoov
marked this pull request as ready for review
June 12, 2026 02:50
Member
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets the Vim mode indicator colors so the status-bar mode shows as a colored pill instead of plain muted text.
Zed's per-mode indicator keys (
vim.<mode>.background/vim.<mode>.foreground, from zed-industries/zed#39813) default to transparent, so without them the indicator falls back to an unstyled-- INSERT --label.Mapping
foampineloveirisForeground is
$basefor every pill, which resolves to dark text on the dark variants and light text on Dawn, keeping the label readable across all three themes. Helix Normal/Select mirror Normal/Visual.Changes
src/template.json— added the 16 vim indicator keys.themes/*.json— regenerated from the template via@rose-pine/build.Testing
Built locally and loaded into Zed; verified the pill renders and contrasts in Normal/Insert/Visual/Replace on Moon (dark) and Dawn (light).
Examples