Remove background for popups #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, sorry for the ping, did you have time to take a look ? |
mvllow
reviewed
Dec 2, 2021
|
Ope so sorry, I added some comments yesterday but didn’t realise you have to “finish review” for them to show 🤭 |
|
Thank you! |
|
Hello @mvllow, I just saw that you reverted this PR, do you have any reason why ? Nevermind, I just saw that you added options to disable it: |
|
Sorry for the confusion! Glad you found the option to enable that again 😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the subtle surface that was not appealing for the eyes:
Before:
After:
Motivated by this: https://www.reddit.com/r/neovim/comments/r5kwg7/rounded_corners_for_popup_menus/