Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NoiceCursor highlight group #138

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

mrtnvgr
Copy link
Contributor

@mrtnvgr mrtnvgr commented Mar 7, 2023

@mvllow
Copy link
Member

mvllow commented Mar 7, 2023

Hmm, the author of Noice said in that issue:

It [Cursor] should be styled the same as the real terminal cursor. (yes, those are not the same)

Noice, however, seems to be doing the opposite. Not a huge fan of changing the cursor for a single plugin because I think GUI Neovim clients use this highlight group the expected way. That being said, I have no problem setting NoiceCursor instead if that works.

@mrtnvgr mrtnvgr changed the title feat: fix Cursor highlight group feat: add NoiceCursor highlight group Mar 8, 2023
@mvllow mvllow merged commit 6535f2d into rose-pine:main Mar 8, 2023
@mvllow
Copy link
Member

mvllow commented Mar 8, 2023

Thank you 💜

@mrtnvgr mrtnvgr deleted the fix-cursor branch March 8, 2023 03:53
mrtnvgr added a commit to mrtnvgr/init.lua that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: NoiceCursor renders incorrently
2 participants