Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Variable and method color should look difference in js/ts #164

Closed
tin-pham opened this issue Jun 14, 2023 · 2 comments · Fixed by #167
Closed

feature: Variable and method color should look difference in js/ts #164

tin-pham opened this issue Jun 14, 2023 · 2 comments · Fixed by #167

Comments

@tin-pham
Copy link

tin-pham commented Jun 14, 2023

Is your feature request related to a problem? Please describe.

Currently it look like this
image

image

Describe the solution you'd like

make it difference

Describe alternatives you've considered

Everything look great except when an object call a method, those 2 look the same
image

Additional context

Great colorscheme, i already use it for 2 year

@mvllow
Copy link
Member

mvllow commented Jun 14, 2023

To clarify, in the example below, would changing exampleMethod from iris to foam solve your issue?

Before

Before screenshot of pseudo code demonstrating Rosé Pine colours—particularly `exampleMethod` and `options` names as iris.

After

Instead of foam, this may be better suited as rose

After screenshot of pseudo code demonstrating Rosé Pine colours—particularly `exampleMethod` name as foam.

@tin-pham
Copy link
Author

Yes that look great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants